Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(usePromiseDialog): add usePromiseDialog hook and Confirm component #163

Closed
wants to merge 1 commit into from

Conversation

kseniya57
Copy link
Contributor

No description provided.

@kseniya57 kseniya57 self-assigned this Mar 13, 2024
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@kseniya57 kseniya57 force-pushed the promise-dialog branch 2 times, most recently from 398296f to 0aa080f Compare March 14, 2024 12:11
Copy link

@IsaevAlexandr IsaevAlexandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks great, but I would suggest making a few changes before the merge

src/hooks/index.ts Outdated Show resolved Hide resolved
src/hooks/usePromiseDialog/PromiseDialogProvider.tsx Outdated Show resolved Hide resolved
src/hooks/usePromiseDialog/PromiseDialogProvider.tsx Outdated Show resolved Hide resolved
src/hooks/usePromiseDialog/PromiseDialogProvider.tsx Outdated Show resolved Hide resolved
src/hooks/usePromiseDialog/PromiseDialogProvider.tsx Outdated Show resolved Hide resolved
@kseniya57 kseniya57 force-pushed the promise-dialog branch 2 times, most recently from 43666f4 to 7850206 Compare March 14, 2024 13:02
@kseniya57
Copy link
Contributor Author

@amje @korvin89 could you please review this

@korvin89
Copy link
Contributor

korvin89 commented Apr 2, 2024

ConfirmDialog has added here #169

@korvin89 korvin89 closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants